Skip to content

Conversation

abonander
Copy link
Contributor

@petrochenkov
Copy link
Contributor

Thanks!
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 3, 2018

📌 Commit 58217ed has been approved by petrochenkov

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 3, 2018
@abonander
Copy link
Contributor Author

@bors r-

@bors
Copy link
Collaborator

bors commented Apr 3, 2018

@abonander: 🔑 Insufficient privileges: Not in reviewers

@abonander
Copy link
Contributor Author

@petrochenkov think I should add regression tests for https://github.com/rust-lang/rust/pull/49350/files#r178706562?

kennytm added a commit to kennytm/rust that referenced this pull request Apr 3, 2018
…etrochenkov

run-pass/attr-stmt-expr: expand test cases

Follow-up to rust-lang#49124 (comment)

r? @petrochenkov
@petrochenkov
Copy link
Contributor

#49350 (comment)
@bors r+

@bors
Copy link
Collaborator

bors commented Apr 3, 2018

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Apr 3, 2018

📌 Commit 58217ed has been approved by petrochenkov

@abonander
Copy link
Contributor Author

Seems like bors should allow a PR author to r- their own PR, but whatever.

kennytm added a commit to kennytm/rust that referenced this pull request Apr 3, 2018
…etrochenkov

run-pass/attr-stmt-expr: expand test cases

Follow-up to rust-lang#49124 (comment)

r? @petrochenkov
bors added a commit that referenced this pull request Apr 3, 2018
Rollup of 14 pull requests

Successful merges:

 - #49179 (Handle future deprecation annotations )
 - #49512 (Add support for variant and types fields for intra links)
 - #49516 (Add missing anchor for union type fields)
 - #49532 (Add test for rustdoc ignore test)
 - #49533 (Add #[must_use] to a few standard library methods)
 - #49570 (avoid IdxSets containing garbage above the universe length)
 - #49594 (Add some performance guidance to std::fs and std::io docs)
 - #49599 (Fix typo)
 - #49603 (Fix url for intra link provided method)
 - #49609 (run-pass/attr-stmt-expr: expand test cases)
 - #49612 (Fix "since" version for getpid feature.)
 - #49618 (Fix build error when compiling libcore for 16bit targets)
 - #49619 (tweak core::fmt docs)
 - #49623 (update mdbook)

Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Apr 4, 2018
…etrochenkov

run-pass/attr-stmt-expr: expand test cases

Follow-up to rust-lang#49124 (comment)

r? @petrochenkov
bors added a commit that referenced this pull request Apr 4, 2018
Rollup of 25 pull requests

Successful merges:

 - #49179 (Handle future deprecation annotations )
 - #49512 (Add support for variant and types fields for intra links)
 - #49515 (fix targetted value background)
 - #49516 (Add missing anchor for union type fields)
 - #49532 (Add test for rustdoc ignore test)
 - #49533 (Add #[must_use] to a few standard library methods)
 - #49540 (Fix miri Discriminant() for non-ADT)
 - #49559 (Introduce Vec::resize_with method (see #41758))
 - #49570 (avoid IdxSets containing garbage above the universe length)
 - #49577 (Stabilize String::replace_range)
 - #49599 (Fix typo)
 - #49603 (Fix url for intra link provided method)
 - #49607 (Stabilize iterator methods in 1.27)
 - #49609 (run-pass/attr-stmt-expr: expand test cases)
 - #49612 (Fix "since" version for getpid feature.)
 - #49618 (Fix build error when compiling libcore for 16bit targets)
 - #49619 (tweak core::fmt docs)
 - #49637 (Stabilize parent_id())
 - #49639 (Update Cargo)
 - #49628 (Re-write the documentation index)
 - #49594 (Add some performance guidance to std::fs and std::io docs)
 - #49625 (miri: add public alloc_kind accessor)
 - #49634 (Add a test for the fix to issue #43058)
 - #49641 (Regression test for #46314)
 - #49547 (Unignore borrowck test)

Failed merges:
@alexcrichton alexcrichton merged commit 58217ed into rust-lang:master Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants